Issue with adding nested index dynamically

classic Classic list List threaded Threaded
47 messages Options
123
Ivan Pavlukhin Ivan Pavlukhin
Reply | Threaded
Open this post in threaded view
|

Re: Issue with adding nested index dynamically

Hi Hemambara,

I appologize but I will be able to share a problematic example only on
next week.

чт, 31 окт. 2019 г. в 19:49, Hemambara <[hidden email]>:

>
> I did not face any issue. Its working fine for me. Can you share your code
> and exception that you are getting
>
> I tried like below and it worked for me.
> ((Person)cache.get(1)).address.community)
>
>
>
>
>
> --
> Sent from: http://apache-ignite-users.70518.x6.nabble.com/



--
Best regards,
Ivan Pavlukhin
Ivan Pavlukhin Ivan Pavlukhin
Reply | Threaded
Open this post in threaded view
|

Re: Issue with adding nested index dynamically

Hi Hemambara,

Check my example [1].
1. Launch step1.
2. Uncomment code and enable Address.number field.
3. Launch step2.

Actually the problem here is type mismatch for "number" int vs
varchar. Work with nested fields could be really tricky. Subsequently
there is not much activity to improve their support. Applying proposed
fix requires thorough testing and review. A lot of end to end
scenarios should be covered by tests.

[1] https://gist.github.com/pavlukhin/53d8a23b48ca0018481a203ceb06065f

пт, 1 нояб. 2019 г. в 11:28, Ivan Pavlukhin <[hidden email]>:

>
> Hi Hemambara,
>
> I appologize but I will be able to share a problematic example only on
> next week.
>
> чт, 31 окт. 2019 г. в 19:49, Hemambara <[hidden email]>:
> >
> > I did not face any issue. Its working fine for me. Can you share your code
> > and exception that you are getting
> >
> > I tried like below and it worked for me.
> > ((Person)cache.get(1)).address.community)
> >
> >
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-users.70518.x6.nabble.com/
>
>
>
> --
> Best regards,
> Ivan Pavlukhin



--
Best regards,
Ivan Pavlukhin
Hemambara Hemambara
Reply | Threaded
Open this post in threaded view
|

Re: Issue with adding nested index dynamically

Okay, so the issue you are facing with is incorrect data type which is valid,
so its not an issue then.

Yes agreed that it requires more testing, but I feel the fix that is going
in, is safe and good to do. This fix is really important for us to proceed
further. I have tested few other scnearios and its working fine for me. Is
there any way we can plan to merge ?  or you do not want to do it now ?



--
Sent from: http://apache-ignite-users.70518.x6.nabble.com/
Ivan Pavlukhin Ivan Pavlukhin
Reply | Threaded
Open this post in threaded view
|

Re: Issue with adding nested index dynamically

Hi Hemambara,

You can a write an email to [hidden email] with reference to
the issue and a description of the fix. It might be that someone will
be ready to do a review and merge.

вт, 5 нояб. 2019 г. в 15:57, Hemambara <[hidden email]>:

>
> Okay, so the issue you are facing with is incorrect data type which is valid,
> so its not an issue then.
>
> Yes agreed that it requires more testing, but I feel the fix that is going
> in, is safe and good to do. This fix is really important for us to proceed
> further. I have tested few other scnearios and its working fine for me. Is
> there any way we can plan to merge ?  or you do not want to do it now ?
>
>
>
> --
> Sent from: http://apache-ignite-users.70518.x6.nabble.com/



--
Best regards,
Ivan Pavlukhin
Hemambara Hemambara
Reply | Threaded
Open this post in threaded view
|

Re: Issue with adding nested index dynamically

Hello, I tried to go to internals and override GridQueryProcessor but somehow
I do not feel like clean solution. Just had another thought...whatever code
I have written and created a pull request for, shall is surround it with -D
arg like nested_field_experimental_feature or with better system property
name. So that my logic will be enabled for the guys that need this feature,
else default to existing logic. Any way as it is mentioned as experimental
feature it leaves the testing part to individuals for thorough testing and
whenever you have time you can get back on this.. if this is fine I will
change code and raise pull request



--
Sent from: http://apache-ignite-users.70518.x6.nabble.com/
Hemambara Hemambara
Reply | Threaded
Open this post in threaded view
|

Re: Issue with adding nested index dynamically

Can anyone please check above comment and update. Thanks



--
Sent from: http://apache-ignite-users.70518.x6.nabble.com/
ilya.kasnacheev ilya.kasnacheev
Reply | Threaded
Open this post in threaded view
|

Re: Issue with adding nested index dynamically

Hello!

I think you should move this discussion over to developers list.

Regards,
--
Ilya Kasnacheev


вт, 26 нояб. 2019 г. в 15:01, Hemambara <[hidden email]>:
Can anyone please check above comment and update. Thanks



--
Sent from: http://apache-ignite-users.70518.x6.nabble.com/
123